Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sh instead of bash as container shell in examples #421

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Use sh instead of bash as container shell in examples #421

merged 1 commit into from
Jul 29, 2023

Conversation

provokateurin
Copy link
Member

Pull Request

Description of the change

Uses sh instead of bash so the examples work in alpine based containers as well. Got introduced in #419

Checklist

jessebot
jessebot approved these changes Jul 29, 2023
View reviewed changes
Copy link
Collaborator

@jessebot jessebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you and sorry about missing that before 🙏

@provokateurin provokateurin merged commit 9cea03f into main Jul 29, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the fix/example-container-shell branch July 29, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebot jessebot jessebot approved these changes

@tvories tvories Awaiting requested review from tvories

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@provokateurin @jessebot